-
Notifications
You must be signed in to change notification settings - Fork 2
NickAkhmetov/Add is_integrated to portal index transformations
#965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ge1.2.0AndPython3.13 Karlburke/move to base image1.2.0 and python3.13
|
@NickAkhmetov, would it make sense to add another flag to differentiate the internally-processed integrated datasets from the externally-processed ones? It seems like we'll need to know that for the UI, but maybe there are existing fields we can use to make that determination. |
|
@yomatters Since we can determine that based on the |
|
@yomatters As part of the review process, can you approve this PR if all looks good to you? I'll take care of the merge and deployment. Our established workflow is to get things tested on DEV and TEST first with full reindex (when necessary like this change). Then the portal team reviews and gives me the green light for PROD release. |
yomatters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
|
@yuanzhou, apologies for the delay! I'm new to the project and wasn't familiar with the process. I just submitted my approval. |
|
Thanks @yomatters. Normally I would get tagged automatically for all the PRs in this repository, and several others too, mainly to coordinate the code review and deployment. For changes like this one, I tend to wait until all other reviewers also approve the PR. Are you a member of the HuBMAP Slack Workspace too? It'll be helpful to include you as I normally keep everyone posted once the changes are running on DEV/TEST and PROD. |
|
@yuanzhou, thanks! Yes, I'm in the HuBMAP Slack. Which channel do you post notifications in? |
|
@yomatters I've added you to |
This PR adds the
is_integratedboolean to the transformation process. All externally processed data and datasets with more than 1 dataset in its ancestor tree are treated as integrated, as:Since this relies on the ancestor dataset counts, I've added this as a separate transformation called in
transform.pyafter theadd_countstransformation and adjusted thetest_transformtests to include integrated dataset cases. I can also add doctests to the function itself if desired.