Remove unsafe code #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying from different slices, std::slice::copy_from_slice is always preferable: it implements bounds-checks, is safe, and also calls into memcpy.
slice::copy_within supports safely copying within a given slice, and is implemented with std::ptr::copy.
|
I have just noticed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::ptr::copy_nonoverlappingwas used to copy between different slices, whereslice::copy_from_slicesafely results in the same call toptr::copy_nonoverlapping.std::ptr::copywas used to move data within a single slice, whereslice::copy_withinsafely results in the same call toptr::copy.