Allow compiling without the qml or network modules#763
Merged
GriffinRichards merged 4 commits intohuderlem:devfrom Aug 8, 2025
Merged
Allow compiling without the qml or network modules#763GriffinRichards merged 4 commits intohuderlem:devfrom
GriffinRichards merged 4 commits intohuderlem:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for building Porymap without either the qml or network modules (we already do this for the charts module).
Without the qml module, the plug-in / API features are disabled, and without the network module the 'check for updates' feature is disabled (this is already disabled on Linux). Both of these features are not critical (and for the majority of users go unused) so we'd rather have users be able to build and use Porymap without needing to sort out their Qt installation. This has come up a few times already, especially for users that have multiple installations of Qt in their environment.
There's a slight maintenance burden here in that the stubbed
Scriptingclass will need to be updated alongside the actual definition when e.g. a new scripting callback is added.