Open
Conversation
Member
|
I'd rather not invent our own protocol. Can we use msgpack or something? |
Author
|
@SomeoneWeird msgpack doesn't handle tcp fragmentation. It just like JSON, but smaller. You still should separate one packet from another and that's why it will also need some kind of packet separator (and this is also "own protocol"). But as msgpack transmitting buffers it will need fixed-length header that will store information about packet data size. |
fix chunked decoder to handle TCP Nagle algorithm packet merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR for handling TCP packet fragmentation. It defines simple protocol with header and data.
Format:
This protocol is needed to handle situations when TCP protocol divide long message into smaller parts to fit MTU.
@SomeoneWeird as for current version of tcp-transport, the new one covers 100% functionality + fragmentation handling. But if it's necessary we can modify protocol to handle true binary data (now it can handle only binary data that doesn't contain any protocol characters). If binary transport is needed, then protocol should be slightly different - with fixed-length header places for metadata. This will lead to maximum data size limit (because we'll have limited number of bytes for data length in header).
PS: Do not rush to merge this PR. Depending on decision on previous question the code could be simplified a bit or rewritten.