Skip to content
This repository was archived by the owner on Dec 28, 2025. It is now read-only.

chore: update release workflow and .gitignore entries #18

Merged
imbajin merged 1 commit into from
Nov 14, 2025
Merged

chore: update release workflow and .gitignore entries #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/validate-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ on:
release_version:
required: true
description: svn release version
default: '1.5.0'
default: '1.7.0'
gpg_user:
required: true
description: current release manager (gpg username)
default: 'vgalaxies'
default: 'Junzhi Peng'

push:
branches:
Expand Down Expand Up @@ -67,6 +67,9 @@ jobs:
if [[ ${{ matrix.os }} =~ "macos" ]]; then
brew install svn
fi
if [[ ${{ matrix.os }} =~ "ubuntu" ]]; then
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The apt-get install command should be preceded by apt-get update to ensure the package index is current. Without updating, the installation may fail if the package index is stale. Consider updating to:

if [[ ${{ matrix.os }} =~ "ubuntu" ]]; then
  sudo apt-get update
  sudo apt-get install -y subversion
fi
Suggested change
if [[ ${{ matrix.os }} =~ "ubuntu" ]]; then
if [[ ${{ matrix.os }} =~ "ubuntu" ]]; then
sudo apt-get update

Copilot uses AI. Check for mistakes.
sudo apt-get install -y subversion
fi
rm -rf dist/${{ inputs.release_version }}
svn co ${URL_PREFIX}/${{ inputs.release_version }} dist/${{ inputs.release_version }}

Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ GEMINI.md
.vscode/settings.json
.aider*
.gemini/
WARP.md
Copy link

@gemini-code-assist gemini-code-assist bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's helpful to add a comment explaining why WARP.md is being ignored. This provides context for other developers, especially since markdown files with all-caps names are often expected to be part of the repository.

# Ignore locally generated WARP file
WARP.md