-
-
Couldn't load subscription status.
- Fork 6
Attempt to replace pkg_resources uses, generally bump to Python 3.10+ maintenance etc. #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thank you! I've been delayed on reviewing but maybe by the end of this week. |
|
I've been trying to think about the reason for the problem on Python 3.14. My best guess is that it's some problem to do with the filenames being the same, i.e. stata.py in nbstata trying to import something from stata.py in pystata. But so far I don't know how to fix. Also I wasn't sure if I needed to add corresponding notebooks for the new _resources.py and _version_helper.py files. |
Hi Tim
I have had a go at this.
I used your ChatGPT suggestions.
I have tested on the most recent versions of Python 3.10, 3.11, 3.12, and 3.13 and they all pass
nbdev_test(as you can see from the GitHub Actions workflow I've amended) and aquarto renderof a test Quarto document.However, I have a mysterious problem. When I run this under the recently released Python 3.14.0 I obtain some sort of problem originating from within Stata's pystata. Weirdly
nbdev_testpasses. But when I run a testquarto renderthe kernel hangs at the first Stata chunk. To see more I converted my test qmd file to a Jupyter notebook.First create a UV virtual environment with Python 3.14.0 and activate it
Then add the packages in the pyproject.toml and nbstata
Install the kernel
Then this will hang, where my test.qmd is simply
Kill that with Ctrl+C and convert qmd file to ipynb
Then open the ipynb in JupyerLab
Then executing a stata chunk, the error I obtain is:
Would you have any ideas? I might ask StataCorp. Tech Support about it.
Anyway even if you don't take this, maybe a useful starting place for your own commits.
Closes #58
Closes #65 (because it includes those commits)