Skip to content

refactor: nit change for get_parameters_from_modules (code debt) #3815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SunMarc merged 2 commits into from
Oct 14, 2025
Merged

refactor: nit change for get_parameters_from_modules (code debt) #3815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92fd856
refactor: nit change for get_parameters_from_modules
kmehant Oct 14, 2025
0c6f1d5
fix: quality check
kmehant Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/accelerate/utils/fsdp_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,11 +630,8 @@ def fsdp2_prepare_model(accelerator, model: torch.nn.Module) -> torch.nn.Module:
# `fully_shard` doesn't accept `None` in case of `MixedPrecisionPolicy`
"mp_policy": fsdp2_plugin.mixed_precision_policy or MixedPrecisionPolicy(),
"mesh": mesh[tuple(accelerator.parallelism_config.fsdp_dim_names)] if mesh is not None else None,
"ignored_params": get_parameters_from_modules(fsdp2_plugin.ignored_modules, model, accelerator.device),
}
if fsdp2_plugin.ignored_modules is not None:
fsdp2_kwargs["ignored_params"] = get_parameters_from_modules(
fsdp2_plugin.ignored_modules, model, accelerator.device
)

model_has_params4bit = False
for name, param in model.named_parameters():
Expand Down Expand Up @@ -808,10 +805,10 @@ def get_parameters_from_modules(
modules (`Union[Iterable[torch.nn.Module], str]`): List of modules

Returns:
`List[torch.nn.Parameter]`: List of parameters
`set[torch.nn.Parameter]`: List of parameters
"""
if modules is None:
return None
return set()
parameters = []
# code taken from accelerate while preparing kwargs for FSDP
if isinstance(modules, str):
Expand Down