Skip to content

add MS-AMP deprecation warnings#3857

Merged
SunMarc merged 2 commits intohuggingface:mainfrom
neha222222:docs-msamp-deprecation
Dec 8, 2025
Merged

add MS-AMP deprecation warnings#3857
SunMarc merged 2 commits intohuggingface:mainfrom
neha222222:docs-msamp-deprecation

Conversation

@neha222222
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add a message also in _prepare_msamp to say that msamp is deprecated and will be removed - redirect to te or torchao ?

@neha222222
Copy link
Contributor Author

hi @SunMarc
Thank you for the review. I have addressed it. Can you please rereview ?
Thanks!

@neha222222 neha222222 requested a review from SunMarc December 5, 2025 19:35
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc SunMarc merged commit 471f7e4 into huggingface:main Dec 8, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants