Skip to content

[SP and CP] error out if both CP and SP enabled#3862

Merged
SunMarc merged 1 commit intohuggingface:mainfrom
kashif:cp-sp-mutual-exclusion
Nov 28, 2025
Merged

[SP and CP] error out if both CP and SP enabled#3862
SunMarc merged 1 commit intohuggingface:mainfrom
kashif:cp-sp-mutual-exclusion

Conversation

@kashif
Copy link
Contributor

@kashif kashif commented Nov 28, 2025

What does this PR do?

We error out early if we enable both SP and CP as they are mutually exclusive.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@kashif kashif requested a review from SunMarc November 28, 2025 14:06
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SunMarc SunMarc merged commit a72834c into huggingface:main Nov 28, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants