Skip to content

Conversation

@SunMarc
Copy link
Member

@SunMarc SunMarc commented Dec 16, 2025

What does this PR do?

This PR fixes #3885. We disable compile in our hooks as it shouldn't be needed since we are just moving data around devices.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc SunMarc requested a review from sayakpaul December 16, 2025 13:10
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@SunMarc SunMarc merged commit db8835c into main Dec 17, 2025
25 of 29 checks passed
@SunMarc SunMarc deleted the hooks-compile-disable branch December 17, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CpuOffload pre_forward and post_forward should have @torch.compiler.disable(), otherwise torch.compile fails in many situations it ought to succeed

4 participants