FSDP2: Activation-checkpoint modules directly matching auto-wrap policy, not those whose parent module matches policy#3909
Open
excepshenal wants to merge 3 commits intohuggingface:mainfrom
Conversation
added 3 commits
January 16, 2026 16:36
…ap_policy after set_auto_wrap_policy in fsdp2_apply_ac
…ete duplicate fsdp2_prepare_auto_wrap_policy
Author
|
Just a light bump @SunMarc or whoever is best to tag for this! Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses #3897 :
fsdp2_prepare_auto_wrap_policywithFullyShardedDataParallelPlugin.set_auto_wrap_policy, and delete extra unnecessary calls toset_auto_wrap_policyConfirmed in test runs of llama-70b training that this fixes AC to checkpoint modules matching auto-wrap policy rather than those whose parent module matches the policy. Compare before:
to after:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.