Prevent double-wrapping models in prepare_model()#3977
Open
joshuaswanson wants to merge 2 commits intohuggingface:mainfrom
Open
Prevent double-wrapping models in prepare_model()#3977joshuaswanson wants to merge 2 commits intohuggingface:mainfrom
joshuaswanson wants to merge 2 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
The CI is not passing, can you check @joshuaswanson ? |
Contributor
Author
|
Fixed, should be green now. The flag wasn't being set in prepare_model() directly, only in prepare(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepare_model()doesn't check if a model has already been prepared, so callingprepare()twice on the same model wraps it in a nested DDP, corrupts the_modelsregistry, and breaks checkpoint save/load with key mismatches likemodule.module.weight.Dataloaders, optimizers, and schedulers already have this guard via
_is_accelerate_prepared. This adds the same check toprepare_model().Closes #3967