Skip to content

[TRANSLATION] translated to fr all units#145

Merged
sergiopaniego merged 8 commits intohuggingface:mainfrom
knoel99:units/fr
Jul 29, 2025
Merged

[TRANSLATION] translated to fr all units#145
sergiopaniego merged 8 commits intohuggingface:mainfrom
knoel99:units/fr

Conversation

@knoel99
Copy link
Copy Markdown
Contributor

@knoel99 knoel99 commented Feb 16, 2025

translated to fr communication, unit0 unit1

@knoel99 knoel99 mentioned this pull request Feb 17, 2025
3 tasks
@burtenshaw burtenshaw changed the title translated to fr communication, unit0 unit1 [TRANSLATION] translated to fr communication, unit0 unit1 Feb 18, 2025
@burtenshaw
Copy link
Copy Markdown
Collaborator

burtenshaw commented Feb 18, 2025

Thanks for the translation @knoel99 !

I will look for a french speaking reviewer and assign them to this PR.

@burtenshaw burtenshaw self-assigned this Feb 18, 2025
@lbourdois
Copy link
Copy Markdown
Contributor

lbourdois commented Mar 9, 2025

Bonjour @knoel99 & @burtenshaw ! 🤗

I had a little time so I reviewed the "communication" and "unit0" parts.
Overall, it seems to me to be of good quality. The remarks mainly concern the fact that words remaining in English should be italicized, that acronyms don't take an “s” at the end in French, that in the meantime the “introduction” page for unit 0 has been updated and there's a layout problem for the discord101.mdx file.

I don't know when I'll be able to review Unit 1.
Concerning this one, I'd like to make sure that there haven't been any new changes in the space of 3 weeks + spread the remarks already made for unit 0 (i.e. the italicized English words and acronyms).

@knoel99
Copy link
Copy Markdown
Contributor Author

knoel99 commented Mar 10, 2025

@lbourdois thanks for your review, Then here is the TODO list:

  • italicized English words and acronyms
  • layout problem for the discord101.mdx file
  • Wait until april for the orignal english version to be stable and then resubmit PR

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Member

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! What is the current state of the translation?
Docs are live but we need to include the new language fr in .github/workflows/build_documentation.yml and .github/workflows/build_pr_documentation.yml so the building process can take it into consideration.

You can see and example for Korean here.

@knoel99
Copy link
Copy Markdown
Contributor Author

knoel99 commented Jul 11, 2025

Thanks for the contribution! What is the current state of the translation? Docs are live but we need to include the new language fr in .github/workflows/build_documentation.yml and .github/workflows/build_pr_documentation.yml so the building process can take it into consideration.

You can see and example for Korean here.

Hello @sergiopaniego , I did the changes in a464bbe

@knoel99 knoel99 changed the title [TRANSLATION] translated to fr communication, unit0 unit1 [TRANSLATION] translated to fr all units Jul 11, 2025
@knoel99
Copy link
Copy Markdown
Contributor Author

knoel99 commented Jul 11, 2025

@lbourdois PR is now up for review. Lot of files :/

@knoel99
Copy link
Copy Markdown
Contributor Author

knoel99 commented Jul 17, 2025

Commit 0aff680 is fixing this :

https://github.com/huggingface/agents-course/actions/runs/16216799455/job/46157982182

2025-07-17T07:53:04.9830215Z Traceback (most recent call last):
2025-07-17T07:53:04.9831382Z   File "/home/runner/work/agents-course/agents-course/.venv/bin/doc-builder", line 10, in <module>
2025-07-17T07:53:04.9832356Z     sys.exit(main())
2025-07-17T07:53:04.9834092Z   File "/home/runner/work/agents-course/agents-course/.venv/lib/python3.10/site-packages/doc_builder/commands/doc_builder_cli.py", line 49, in main
2025-07-17T07:53:04.9835277Z     args.func(args)
2025-07-17T07:53:04.9836152Z   File "/home/runner/work/agents-course/agents-course/.venv/lib/python3.10/site-packages/doc_builder/commands/build.py", line 102, in build_command
2025-07-17T07:53:04.9836929Z     build_doc(
2025-07-17T07:53:04.9837714Z   File "/home/runner/work/agents-course/agents-course/.venv/lib/python3.10/site-packages/doc_builder/build_doc.py", line 371, in build_doc
2025-07-17T07:53:04.9838579Z     sphinx_refs = check_toc_integrity(doc_folder, output_dir)
2025-07-17T07:53:04.9839525Z   File "/home/runner/work/agents-course/agents-course/.venv/lib/python3.10/site-packages/doc_builder/build_doc.py", line 478, in check_toc_integrity
2025-07-17T07:53:04.9840302Z     raise RuntimeError(
2025-07-17T07:53:04.9840817Z RuntimeError: The following files are not present in the table of contents:
2025-07-17T07:53:04.9841304Z - unit1/get-your-certificate
2025-07-17T07:53:04.9841617Z - communication/next-units
2025-07-17T07:53:04.9842008Z Add them to ../agents-course/units/fr/_toctree.yml.
2025-07-17T07:53:05.0309067Z ##[error]Process completed with exit code 1.

Copy link
Copy Markdown
Member

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing it!

The building procedure is generating an error in unit0/onboarding.mdx as I think some parts are missing

<img src="https://huggingface.co/datasets/agents-course/course-images/resolve/main/en/communication/share.png

Missing parts here...

That image is not closed, for example and some parts are missing. Can we restore them? :)

@knoel99
Copy link
Copy Markdown
Contributor Author

knoel99 commented Jul 17, 2025

Commit 28c7857 fixes the troncated text and updates the docs based on the updated english version

@sergiopaniego
Copy link
Copy Markdown
Member

PR docs: https://moon-ci-docs.huggingface.co/learn/agents-course/pr_145/fr/unit0/introduction

Copy link
Copy Markdown
Member

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci for the huge effort @knoel99!

I'll let @lbourdois review the content in français :)
btw, you both can add yourselves in the acknowledgments section as French translators.

Copy link
Copy Markdown
Member

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @knoel99!!

cc @lbourdois

@sergiopaniego sergiopaniego merged commit 41515cf into huggingface:main Jul 29, 2025
1 check passed
@lbourdois lbourdois mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants