[TRANSLATION] translated to fr all units#145
Conversation
|
Thanks for the translation @knoel99 ! I will look for a french speaking reviewer and assign them to this PR. |
|
Bonjour @knoel99 & @burtenshaw ! 🤗 I had a little time so I reviewed the "communication" and "unit0" parts. I don't know when I'll be able to review Unit 1. |
|
@lbourdois thanks for your review, Then here is the TODO list:
|
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sergiopaniego
left a comment
There was a problem hiding this comment.
Thanks for the contribution! What is the current state of the translation?
Docs are live but we need to include the new language fr in .github/workflows/build_documentation.yml and .github/workflows/build_pr_documentation.yml so the building process can take it into consideration.
You can see and example for Korean here.
Hello @sergiopaniego , I did the changes in a464bbe |
|
@lbourdois PR is now up for review. Lot of files :/ |
|
Commit 0aff680 is fixing this : https://github.com/huggingface/agents-course/actions/runs/16216799455/job/46157982182 |
sergiopaniego
left a comment
There was a problem hiding this comment.
Thanks for pushing it!
The building procedure is generating an error in unit0/onboarding.mdx as I think some parts are missing
<img src="https://huggingface.co/datasets/agents-course/course-images/resolve/main/en/communication/share.png
Missing parts here...
That image is not closed, for example and some parts are missing. Can we restore them? :)
|
Commit 28c7857 fixes the troncated text and updates the docs based on the updated english version |
sergiopaniego
left a comment
There was a problem hiding this comment.
Merci for the huge effort @knoel99!
I'll let @lbourdois review the content in français :)
btw, you both can add yourselves in the acknowledgments section as French translators.
sergiopaniego
left a comment
There was a problem hiding this comment.
Thanks @knoel99!!
cc @lbourdois
translated to fr communication, unit0 unit1