-
Notifications
You must be signed in to change notification settings - Fork 1.7k
🌐 [i18n-KO] Translated unit4 introduction.mdx to Korean
#603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
xhaktm00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전체적으로 자연스러운 번역인 것 같습니다. 고생 많으셨습니다!
다만, 기존 번역에서 Unit 용어를 번역하지 않고 그대로 사용했어서, ‘유닛’ 대신 ‘Unit’ 표기 유지 제안드립니다. 확인 부탁드립니다!
harheem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정님의 제안 사항 반영하면 Approve 드리겠습니다 👍🏻
Co-authored-by: Lee SuJung <[email protected]>
|
@harheem 수정님 제안사항 반영했습니다. |
|
Hi @Youngdong2 |
What does this PR do?
Translated the
unit4 introduction.mdxfile of the documentation to Korean.Thank you in advance for your review.
Part of huggingface/transformers#20179
Before reviewing
[[lowercased-header]])Who can review? (Initial)
May you please review this PR?
@harheem, @nsbg, @Youngdong2, @xhaktm00, @Judy-Choi
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)