Skip to content

Conversation

@hlky
Copy link
Contributor

@hlky hlky commented Feb 28, 2025

</video>
</figure>

### Options
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusing for the average reader imo. Developers can check the docstrings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to keep it. We can add a note "Users are not required to go through this" or something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was also outdated, will add it back based on current docstrings.

image = remote_decode(
endpoint="https://q1bj3bpq6kzilnsu.us-east-1.aws.endpoints.huggingface.cloud/",
tensor=latent,
scaling_factor=0.18215,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss how users can get this value I think.

Something like:

from huggingface_hub import hf_hub_download

file_path = hf_hub_download(repo_id, filename="vae/config.json")

...

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@hlky hlky merged commit 689c8d1 into main Mar 2, 2025
@hlky hlky deleted the remote-vae-updates branch March 2, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants