feat: add DEFAULT_MAX_TOKENS env variable for global token limit#2069
Open
AviadHayumi wants to merge 1 commit intohuggingface:mainfrom
Open
feat: add DEFAULT_MAX_TOKENS env variable for global token limit#2069AviadHayumi wants to merge 1 commit intohuggingface:mainfrom
AviadHayumi wants to merge 1 commit intohuggingface:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24017e6f5a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
24017e6 to
0a4586e
Compare
Collaborator
|
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
DEFAULT_MAX_TOKENSenvironment variable that sets a global default formax_tokensacross all models, eliminating the need to configuremax_tokensindividually for each model in theMODELSenv var.Why
When using OpenAI-compatible backends like NVIDIA NIM, not setting
max_tokenscan cause issues:Input length + max new tokens > max sequence lengthBefore this change, users had to configure both
OPENAI_BASE_URLandMODELSjust to setmax_tokens:OPENAI_BASE_URL=http://nim-service.namespace.svc.cluster.local/v1 MODELS='[{"id":"meta/llama-3.1-8b-instruct","name":"Llama 3.1 8B (NIM)","parameters":{"max_tokens":4096}}]'After this change, users can simply set:
This is much simpler - no need to duplicate the model ID/name or use the
MODELSconfig just for setting token limits.Changes
src/lib/server/config.tsDEFAULT_MAX_TOKENStoExtraConfigKeystypesrc/lib/server/endpoints/openai/endpointOai.tsDEFAULT_MAX_TOKENSas fallback when model'smax_tokensparameter is not setTest plan
npm run checkpassesmax_tokensvaluesparameters.max_tokensstill takes priority overDEFAULT_MAX_TOKENS