Skip to content

fix(security): use timing-safe comparison for admin token #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tessaherself wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(security): use timing-safe comparison for admin token #2185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4ee8ab
fix(security): use timing-safe comparison for admin token validation
tessaherself Mar 16, 2026
58813b2
fix: use length check instead of padEnd in timing-safe compare
tessaherself Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/lib/server/adminToken.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@ import { config } from "$lib/server/config";
import type { Session } from "$lib/types/Session";
import { logger } from "./logger";
import { v4 } from "uuid";
import { timingSafeEqual } from "crypto";

/** Constant-time string comparison to prevent timing attacks on admin token. */
function safeCompare(a: string, b: string): boolean {
if (a.length !== b.length) return false;
const bufA = Buffer.from(a);
const bufB = Buffer.from(b);
return timingSafeEqual(bufA, bufB);
}

class AdminTokenManager {
private token = config.ADMIN_TOKEN || v4();
Expand All @@ -19,7 +28,7 @@ class AdminTokenManager {

public checkToken(token: string, sessionId: Session["sessionId"]) {
if (!this.enabled) return false;
if (token === this.token) {
if (safeCompare(token, this.token)) {
logger.info(`[ADMIN] Token validated`);
this.adminSessions.push(sessionId);
this.token = config.ADMIN_TOKEN || v4();
Expand Down