Open
Conversation
mmhamdy
approved these changes
Dec 30, 2024
Contributor
mmhamdy
left a comment
There was a problem hiding this comment.
Thanks for catching this!🤗 Just checked the diffusion section and found that there are only two channels (no #discussions channel).
| - `#3d`: a channel to discuss aspects of computer vision specific to 3D computer vision | ||
|
|
||
| If you are interested in generative AI, we also invite you to join all channels related to the Diffusion Models: #core-announcements, #discussions, #dev-discussions, and #diff-i-made-this. | ||
| If you are interested in generative AI, we also invite you to join all channels related to the Diffusion Models: #core-announcements, #discussions, #dev-discussions, and #i-made-this. |
Contributor
There was a problem hiding this comment.
Suggested change
| If you are interested in generative AI, we also invite you to join all channels related to the Diffusion Models: #core-announcements, #discussions, #dev-discussions, and #i-made-this. | |
| If you are interested in generative AI, we also invite you to join all channels related to the Diffusion Models: #core-announcements, #dev-discussions, and #i-made-this to share your work with the community. |
Collaborator
|
Thanks for catching this 🙂 Actually the #diff-i-made-this channel was separate from the current #i-made-this-channel, specifically for Diffusion Model related creations. However it was removed some time during the year. I think it is okay to reference to the general #i-made-this channel anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Updated references to Discord channels
Changes:
Added updated references to Discord channels in line 55 and 58 of file chapters\es\unit0\welcome\welcome.mdx
fix https://github.com/johko/computer-vision-course/issues/372
Adding @sergiopaniego as reviewer here since I can't add him in the actual PR.
Thanks! :)