Skip to content

[i18n-ko] Translated vector_search_with_hub_as_backend.ipynb to Korean#299

Merged
stevhliu merged 9 commits intohuggingface:mainfrom
whybe-choi:docs/vector_search_with_hub_as_backend
Sep 18, 2025
Merged

[i18n-ko] Translated vector_search_with_hub_as_backend.ipynb to Korean#299
stevhliu merged 9 commits intohuggingface:mainfrom
whybe-choi:docs/vector_search_with_hub_as_backend

Conversation

@whybe-choi
Copy link
Contributor

@whybe-choi whybe-choi commented May 13, 2025

What does this PR do?

Translated the vector_search_with_hub_as_backend.ipynb file to Korean.

Who can review?

Hello, @merveenoyan ! Could you please review my PR when you have a chance?
Thank you :)

@review-notebook-app
Copy link

review-notebook-app bot commented May 13, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@whybe-choi whybe-choi changed the title [i18n-ko] Translated vector_search_with_hub_as_backend.ipynb to Korean [i18n-ko] Translated vector_search_with_hub_as_backend.ipynb to Korean May 17, 2025
@merveenoyan
Copy link
Collaborator

merveenoyan commented May 19, 2025

Hello and thanks for this PR! Can we get another Korean speaker to check this 👀

@mreraser
Copy link
Contributor

mreraser commented May 21, 2025

Hello and thanks for this PR! Can we get another Korean speaker to check this 👀

Hello @whybe-choi! May I review your translation?

mreraser
mreraser reviewed May 21, 2025
View reviewed changes
Copy link
Contributor

@mreraser mreraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice translation! Good job 👍

Here are a few suggestions!

whybe-choi and others added 6 commits September 17, 2025 00:17
@whybe-choi @mreraser
Update notebooks/ko/_toctree.yml
082bc94 
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
@whybe-choi @mreraser
Update notebooks/ko/vector_search_with_hub_as_backend.ipynb
8ec104e 
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
@whybe-choi @mreraser
Update notebooks/ko/vector_search_with_hub_as_backend.ipynb
954294b 
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
@whybe-choi @mreraser
Update notebooks/ko/vector_search_with_hub_as_backend.ipynb
8bf65f1 
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
@whybe-choi @mreraser
Update notebooks/ko/index.md
9c0ce48 
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
@whybe-choi
Merge branch 'main' into docs/vector_search_with_hub_as_backend
90516ca
@whybe-choi
Copy link
Contributor Author

whybe-choi commented Sep 18, 2025

Hi, @stevhliu !
I would be grateful for your feedback on this PR when you have a spare moment🙂
Your insights would be very helpful. Thank you for your time!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 18, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! 🙌

@stevhliu stevhliu merged commit f3ecb3d into huggingface:main Sep 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevhliu stevhliu stevhliu approved these changes

+1 more reviewer

@mreraser mreraser mreraser left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@whybe-choi @merveenoyan @mreraser @HuggingFaceDocBuilderDev @stevhliu