fix(worker): retry heartbeat if JobDocument is not yet available #3205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes huggingface#2532 When a worker sends a heartbeat immediately after job assignment, it may race with job persistence, resulting in: `JobDocument matching query does not exist`. This patch adds retry logic to the `WorkerExecutor.heartbeat()` method in `executor.py`, retrying the heartbeat a few times (with delay) if this specific error occurs. This avoids false negatives and unnecessary worker shutdowns on transient states. Retries: 6 attempts Delay: 0.5s between retries Only the specific "JobDocument not found" error is retried — other exceptions still raise immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2532
Adds a retry loop in
WorkerExecutor.heartbeat()to handle the case where the heartbeat is sent before the JobDocument has been persisted."JobDocument matching query does not exist"is detected