Skip to content

feat(rows): exclude heavy binary columns from /rows response to avoid UI lag (#3052) #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(rows): exclude heavy binary columns from /rows response to avoid UI lag (#3052) #3209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions services/rows/src/rows/routes/rows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"halabi2016/arabic_speech_corpus"
] # for testing

EXCLUDED_COLUMNS = {"vae_latents", "t5_prompt_embeds"}

def create_rows_endpoint(
cached_assets_storage_client: StorageClient,
Expand Down Expand Up @@ -106,6 +107,7 @@ async def rows_endpoint(request: Request) -> Response:
except TooBigRows as err:
raise TooBigContentError(str(err)) from None
with StepProfiler(method="rows_endpoint", step="transform to a list"):
pa_table = pa_table.drop([col for col in pa_table.column_names if col in EXCLUDED_COLUMNS])
response = await create_response(
dataset=dataset,
revision=revision,
Expand Down