Skip to content

fix: None default with bool type on load creates typing error #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhoestq merged 2 commits into from
Mar 4, 2025
Merged

fix: None default with bool type on load creates typing error #7426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8af570
fix typing on load
stephantul Feb 27, 2025
2c28496
fix docstring
stephantul Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/datasets/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,7 +1507,7 @@ def dataset_module_factory(
Directory to read/write data. Defaults to `"~/.cache/huggingface/datasets"`.

<Added version="2.16.0"/>
trust_remote_code (`bool`, defaults to `False`):
trust_remote_code (`bool`, *optional*, defaults to `None`):
Whether or not to allow for datasets defined on the Hub using a dataset script. This option
should only be set to `True` for repositories you trust and in which you have read the code, as it will
execute code present on the Hub on your local machine.
Expand Down Expand Up @@ -1809,7 +1809,7 @@ def load_dataset_builder(
**Experimental**. Key/value pairs to be passed on to the dataset file-system backend, if any.

<Added version="2.11.0"/>
trust_remote_code (`bool`, defaults to `False`):
trust_remote_code (`bool`, *optional*, defaults to `None`):
Whether or not to allow for datasets defined on the Hub using a dataset script. This option
should only be set to `True` for repositories you trust and in which you have read the code, as it will
execute code present on the Hub on your local machine.
Expand Down Expand Up @@ -1920,7 +1920,7 @@ def load_dataset(
streaming: bool = False,
num_proc: Optional[int] = None,
storage_options: Optional[Dict] = None,
trust_remote_code: bool = None,
trust_remote_code: Optional[bool] = None,
**config_kwargs,
) -> Union[DatasetDict, Dataset, IterableDatasetDict, IterableDataset]:
"""Load a dataset from the Hugging Face Hub, or a local dataset.
Expand Down Expand Up @@ -2029,7 +2029,7 @@ def load_dataset(
**Experimental**. Key/value pairs to be passed on to the dataset file-system backend, if any.

<Added version="2.11.0"/>
trust_remote_code (`bool`, defaults to `False`):
trust_remote_code (`bool`, *optional*, defaults to `None`):
Whether or not to allow for datasets defined on the Hub using a dataset script. This option
should only be set to `True` for repositories you trust and in which you have read the code, as it will
execute code present on the Hub on your local machine.
Expand Down