Skip to content

Pass user-agent from DownloadConfig into fsspec storage_options #7631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass user-agent from DownloadConfig into fsspec storage_options #7631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/datasets/utils/file_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
import huggingface_hub
import huggingface_hub.errors
import requests
from .file_utils import get_datasets_user_agent # If needed
from ..download.download_config import DownloadConfig
from fsspec.core import strip_protocol, url_to_fs
from fsspec.utils import can_be_local
from huggingface_hub.utils import EntryNotFoundError, get_session, insecure_hashlib
Expand Down Expand Up @@ -894,6 +896,13 @@ def _prepare_single_hop_path_and_storage_options(
# streaming with block_size=0 is only implemented in 0.21 (see https://github.com/huggingface/huggingface_hub/pull/1967)
if config.HF_HUB_VERSION < version.parse("0.21.0"):
storage_options["block_size"] = "default"

if download_config is not None:
user_agent = get_datasets_user_agent(download_config.user_agent)
if protocol in {"http", "https", "hf"}:
storage_options.setdefault("headers", {})
storage_options["headers"]["user-agent"] = user_agent

if storage_options:
storage_options = {protocol: storage_options}
return urlpath, storage_options
Expand Down