Skip to content

Fix 7846: add_column and add_item erroneously(?) require new_fingerprint parameter #7884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhoestq merged 5 commits into from
Dec 4, 2025
Merged

Fix 7846: add_column and add_item erroneously(?) require new_fingerprint parameter #7884

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e209a91
fix 7846
sajmaru Nov 27, 2025
ace61f0
Update tests/test_arrow_dataset.py
lhoestq Dec 4, 2025
e5f0bb5
make style
lhoestq Dec 4, 2025
0812e76
Update arrow_dataset.py
lhoestq Dec 4, 2025
5ad9858
make style
lhoestq Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/datasets/arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6076,7 +6076,7 @@ def get_deletions_and_dataset_card() -> tuple[str, list[CommitOperationDelete],
@transmit_format
@fingerprint_transform(inplace=False)
def add_column(
self, name: str, column: Union[list, np.ndarray], new_fingerprint: str, feature: Optional[FeatureType] = None
self, name: str, column: Union[list, np.ndarray], new_fingerprint: Optional[str] = None, feature: Optional[FeatureType] = None
):
"""Add column to Dataset.

Expand Down Expand Up @@ -6333,7 +6333,7 @@ def add_elasticsearch_index(

@transmit_format
@fingerprint_transform(inplace=False)
def add_item(self, item: dict, new_fingerprint: str):
def add_item(self, item: dict, new_fingerprint: Optional[str] = None):
"""Add item to Dataset.

<Added version="1.7"/>
Expand Down
8 changes: 8 additions & 0 deletions tests/test_arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4783,3 +4783,11 @@ def test_from_polars_save_to_disk_and_load_from_disk_round_trip_with_large_list(
def test_polars_round_trip():
ds = Dataset.from_dict({"x": [[1, 2], [3, 4, 5]], "y": ["a", "b"]})
assert isinstance(Dataset.from_polars(ds.to_polars()), Dataset)

def test_add_column_and_item_without_fingerprint():
from datasets import Dataset
ds = Dataset.from_dict({"a": [1, 2]})

# add column
ds2 = ds.add_column("b", [3, 4])
assert "b"