Skip to content

Fix load_from_disk progress bar with redirected stdout #7919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhoestq merged 5 commits into from
Jan 16, 2026
+4 −0
Merged

Fix load_from_disk progress bar with redirected stdout #7919

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
791ff31
Fix load_from_disk progress bar with redirected stdout
omarfarhoud Dec 28, 2025
6d49f5f
Run ruff format
omarfarhoud Dec 28, 2025
b4df2c4
Check TQDM_POSITION to force-enable progress in cloud environments
omarfarhoud Dec 29, 2025
938950b
Move TQDM_POSITION check to tqdm class for all progress bars
omarfarhoud Dec 29, 2025
697882c
Merge branch 'main' into fix-load-from-disk-progress-bar
omarfarhoud Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/datasets/arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,7 +1798,8 @@ def load_from_disk(
tqdm_class=hf_tqdm,
desc="Loading dataset from disk",
# set `disable=None` rather than `disable=False` by default to disable progress bar when no TTY attached
disable=len(state["_data_files"]) <= 16 or None,
# unless TQDM_POSITION=-1 is set (cloud environments)
disable=len(state["_data_files"]) <= 16 or (None if os.getenv("TQDM_POSITION") != "-1" else False),
)
)

Expand Down
Loading