Skip to content

Conversation

@Scott-Simmons
Copy link
Contributor

@Scott-Simmons Scott-Simmons commented Jan 2, 2026

Solves #7928

Raise early for invalid revisions

@Scott-Simmons
Copy link
Contributor Author

Scott-Simmons commented Jan 2, 2026

Passes

pytest -k "LoadTest and test_load_dataset_invalid_revision_with_cache"

Fails

git checkout cc2399019a3a547ebc31ec68a1ff99abd4ec93ce
pytest -k "LoadTest and test_load_dataset_invalid_revision_with_cache"

Ran make test, but failures look unrelated to the PR diff (same tests fail on main too)

FAILED tests/test_distributed.py::test_torch_distributed_run[False] - TypeError: Passing coroutines is forbidden...
FAILED tests/test_distributed.py::test_torch_distributed_run[True] - TypeError: Passing coroutines is forbidden...
FAILED tests/test_distributed.py::test_torch_distributed_run_streaming_with_num_workers[2-2] - TypeError: Passing coroutines is forbidden...
FAILED tests/test_distributed.py::test_torch_distributed_run_streaming_with_num_workers[3-2] - TypeError: Passing coroutines is forbidden...
= 4 failed, 3077 passed, 18 skipped, 491 warnings in 556.45s (0:09:16) =
make: *** [Makefile:20: test] Error 1

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lhoestq lhoestq merged commit 7bdf840 into huggingface:main Jan 9, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants