Skip to content

Fix duplicate keyword conflict in load_dataset_builder #7932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ashish570raj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix duplicate keyword conflict in load_dataset_builder #7932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/datasets/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,21 +1167,31 @@ def load_dataset_builder(
raise ValueError(error_msg)

builder_cls = get_dataset_builder_class(dataset_module, dataset_name=dataset_name)
# Instantiate the dataset builder
# Merge builder_kwargs and config_kwargs safely
# merged_kwargs = {**builder_kwargs, **config_kwargs}
# Merge kwargs safely
merged_kwargs = {**builder_kwargs, **config_kwargs}

# Remove arguments that are passed explicitly
# merged_kwargs.pop("config_name", None)
merged_kwargs.pop("dataset_name", None)
merged_kwargs.pop("data_dir", None)
merged_kwargs.pop("data_files", None)

builder_instance: DatasetBuilder = builder_cls(
cache_dir=cache_dir,
dataset_name=dataset_name,
config_name=config_name,
# config_name=config_name,
data_dir=data_dir,
data_files=data_files,
hash=dataset_module.hash,
info=info,
features=features,
token=token,
storage_options=storage_options,
**builder_kwargs,
**config_kwargs,
**merged_kwargs,
)

builder_instance._use_legacy_cache_dir_if_possible(dataset_module)

return builder_instance
Expand Down
Loading