-
Couldn't load subscription status.
- Fork 6.5k
Deep Compression Autoencoder (refactored) #10064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/diffusers/models/normalization.py
Co-authored-by: YiYi Xu <[email protected]>
|
I've moved LiteMLA to the same file as VAE btw for the time being. If it is used in the transformer implementation as well, we could consider placing it in |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@a-r-r-o-w Thanks for your work! I'm wondering whether @lawrence-cj and I can add commits to this PR. I see some minor issues such as Also, according to @yiyixuxu 's previous comments, I think |
|
I think those functions should be okay for now since we've made it minimal, but we can wait for another review. I think it's okay because otherwise there would be some copied if-else logic that would make the code a bit more bloated. Regarding your team being able to push to this PR, I'm not sure if github would allow that without us adding some permissions in HF org. Instead I will try resolving conflicts with your original branch and push it there in some time, does that work? |
Sounds great. Let's do it! @a-r-r-o-w |
|
Closing in favor of original PR where these changes have now been merged |
Based on the code from #9708, this is a modified implementation of DCAE to follow some of Diffusers convention.
I believe this should be good for an initial review @yiyixuxu. We can do two things:
I think either should be okay but if we are okay with continuing in this one, @lawrence-cj could you please let me know all the co-authors I need to add to this PR 🤗 So far, only you and @chenjy2003 are added (because I forked off your PR branch).
I believe this version matches the original Sana VAE checkpoint completely. I am yet to verify the correctness of all the other variants, so I'll share the unit tests after completing this testing.
To run the conversion, I use:
Here is some inference code for testing:
code
I think it is okay to skip the diffusers-side VAE tests for now, and pick it up in a follow up PR after #9808 is merged. Will add the documentation after verifying all checkpoints work as expected and finalizing the diffusers implementation following reviews.
cc: @lawrence-cj @chenjy2003