Skip to content

[Tests] fix condition argument in xfail. #10099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2024
Merged

[Tests] fix condition argument in xfail. #10099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc7247b
fix condition argument in xfail.
sayakpaul Dec 3, 2024
d33be27
revert init changes.
sayakpaul Dec 3, 2024
a64c9b6
Merge branch 'main' into fix-condition-xfail
sayakpaul Dec 4, 2024
31d55b7
Merge branch 'main' into fix-condition-xfail
sayakpaul Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/lora/test_lora_layers_cogvideox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def get_dummy_inputs(self, with_generator=True):

@skip_mps
@pytest.mark.xfail(
condtion=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"),
condition=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"),
reason="Test currently fails on CPU and PyTorch 2.5.1 but not on PyTorch 2.4.1.",
strict=True,
)
Expand Down
2 changes: 1 addition & 1 deletion tests/lora/test_lora_layers_mochi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def get_dummy_inputs(self, with_generator=True):
return noise, input_ids, pipeline_inputs

@pytest.mark.xfail(
condtion=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"),
condition=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"),
reason="Test currently fails on CPU and PyTorch 2.5.1 but not on PyTorch 2.4.1.",
strict=True,
)
Expand Down
2 changes: 1 addition & 1 deletion tests/lora/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,7 +1513,7 @@ def test_simple_inference_with_text_denoiser_multi_adapter_weighted(self):

@skip_mps
@pytest.mark.xfail(
condtion=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"),
condition=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"),
reason="Test currently fails on CPU and PyTorch 2.5.1 but not on PyTorch 2.4.1.",
strict=True,
)
Expand Down
Loading