Skip to content

Conversation

@hlky
Copy link
Contributor

@hlky hlky commented Dec 3, 2024

What does this PR do?

This PR adds test_skip_guidance_layers to SD3 pipeline to check skip_guidance_layers with num_images_per_prompt.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul @DN6

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Dec 3, 2024

but we only have sd3 that support this and do not have plan to extend to others, (I think @asomoza run some tests, it's not even conclusive that it improves the image for SD3)
maybe just add to sd3 test?

@hlky hlky changed the title Test skip_guidance_layers in pipelines Test skip_guidance_layers in SD3 pipeline Dec 3, 2024
@hlky
Copy link
Contributor Author

hlky commented Dec 3, 2024

Thanks! Moved it to SD3 pipeline.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit cfdeebd into huggingface:main Dec 4, 2024
11 checks passed
lawrence-cj pushed a commit to lawrence-cj/diffusers that referenced this pull request Dec 4, 2024
* Test `skip_guidance_layers` in pipelines

* Move to test_pipeline_stable_diffusion_3
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* Test `skip_guidance_layers` in pipelines

* Move to test_pipeline_stable_diffusion_3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants