Skip to content

Conversation

@hlky
Copy link
Contributor

@hlky hlky commented Dec 12, 2024

What does this PR do?

Fixes #9906

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yiyixuxu @asomoza

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@asomoza
Copy link
Member

asomoza commented Dec 12, 2024

thanks @hlky, can you please change the example here for the one where the encoding is done outside of the loop? Probably best to have the more correct example in the showcase.

@hlky
Copy link
Contributor Author

hlky commented Dec 12, 2024

@asomoza I've changed the example for version with encoding outside of the loop and added the XL version.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@asomoza asomoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hlky hlky merged commit f2d348d into huggingface:main Dec 12, 2024
12 checks passed
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* Remove `negative_*` from SDXL callback

* Change example and add XL version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stable Diffusion and SDXL Callbacks are fundamentally broken for prompt_embeds

4 participants