[tests] Fix broken cuda, nightly and lora tests on main for CogVideoX #10270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The device-related failing tests are now passing:
Not completely sure why the xfail ones are failing. Will look at it separately |
DN6
approved these changes
Dec 18, 2024
Foundsheep
pushed a commit
to Foundsheep/diffusers
that referenced
this pull request
Dec 23, 2024
…huggingface#10270) fix joint pos embedding device
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
…#10270) fix joint pos embedding device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests seem to be failing for CogVideoX on
main.After bisecting between Dec. 1st to today, I found that it starts to break in #10156. The test failures are understandable because the scale of changes is large, and we only run Fast CPU tests on PRs (we only fail on CUDA related tests which are not run until something is in main). The fix in this PR is how the original implementation should've been