Skip to content

[Tests] QoL improvements to the LoRA test suite #10304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 23, 2024
Merged

[Tests] QoL improvements to the LoRA test suite #10304

merged 8 commits into from
Dec 23, 2024

Conversation

@sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Dec 19, 2024 •
edited
Loading

What does this PR do?

  • Removes test_lora_fuse_nan() from the LTX LoRA test suite as that is handled in tests/lora/utils.py.
  • Moves test_lora_B_bias and test_correct_lora_configs_with_different_ranks to utils.py from the Control LoRA tests for Flux. This is because the corresponding features apply generally.
  • Other misc things.

@sayakpaul sayakpaul requested review from DN6 and a-r-r-o-w December 19, 2024 12:57
sayakpaul
sayakpaul commented Dec 19, 2024
View reviewed changes
a-r-r-o-w
a-r-r-o-w reviewed Dec 23, 2024
View reviewed changes
a-r-r-o-w
a-r-r-o-w approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The test for lora_B bias is moved under utils.py which means it will be run with every model now, no? This is okay, but maybe good to make note that it only matters for Flux currently as there are no other lora checkpoints with lora B bias yet I think

@sayakpaul
Copy link
Member Author

LGTM! The test for lora_B bias is moved under utils.py which means it will be run with every model now, no? This is okay, but maybe good to make note that it only matters for Flux currently as there are no other lora checkpoints with lora B bias yet I think

Note added.

@sayakpaul sayakpaul merged commit c34fc34 into main Dec 23, 2024
11 checks passed
@sayakpaul sayakpaul deleted the lora-tests-misc branch December 23, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6 DN6 Awaiting requested review from DN6

1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayakpaul @a-r-r-o-w