Skip to content

Conversation

@hlky
Copy link
Contributor

@hlky hlky commented Dec 20, 2024

What does this PR do?

Torch Pipelines CUDA Tests (kandinsky) is failing due to enable_sequential_cpu_offload changing

FAILED tests/pipelines/kandinsky/test_kandinsky_combined.py::KandinskyPipelineInpaintCombinedFastTests::test_sequential_offload_forward_pass_twice - TypeError: KandinskyInpaintCombinedPipeline.enable_sequential_cpu_offload() got an unexpected keyword argument 'device'

The combined pipeline overrides enable_sequential_cpu_offload to set it on both components and had the outdated signature.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@hlky hlky requested a review from yiyixuxu December 21, 2024 18:43
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit f615f00 into huggingface:main Dec 23, 2024
12 checks passed
sayakpaul added a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants