Skip to content

Update Flux docstrings #10423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

Update Flux docstrings #10423

merged 1 commit into from
Jan 2, 2025

Conversation

@a-r-r-o-w
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w commented Jan 1, 2025 •
edited
Loading

  • Updates some docs and type hints
  • Removes the access of attributes via config in transformer init
  • torch.FloatTensor -> torch.Tensor because FloatTensor only exists for backward-compatibility reasons

@a-r-r-o-w a-r-r-o-w requested review from hlky and stevhliu January 1, 2025 21:44
a-r-r-o-w
a-r-r-o-w commented Jan 1, 2025
View reviewed changes
src/diffusers/models/transformers/transformer_flux.py
):
super().__init__()
self.out_channels = out_channels or in_channels
self.inner_dim = self.config.num_attention_heads * self.config.attention_head_dim
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't really prefer accessing readily available init attributes via the config. I think we were okay with doing this here

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit 476795c into main Jan 2, 2025
15 checks passed
@yiyixuxu yiyixuxu deleted the flux-docstrings-update branch January 2, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevhliu stevhliu Awaiting requested review from stevhliu

1 more reviewer

@hlky hlky hlky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@a-r-r-o-w @HuggingFaceDocBuilderDev @hlky @yiyixuxu