Skip to content

Conversation

@sayakpaul
Copy link
Member

No description provided.

@sayakpaul sayakpaul requested a review from hlky January 11, 2025 04:04
Comment on lines 793 to 795
# should this not be like the following?
# has_neg_prompt = negative_prompt is not None or (negative_prompt_embeds is not None and negative_pooled_prompt_embeds is not None)
# do_true_cfg = true_cfg_scale > 1 and has_neg_prompt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a question. Will discard once answered/resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. I have removed it for now in this PR. Will open a separate PR with a test.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul merged commit 0785dba into main Jan 12, 2025
15 checks passed
@sayakpaul sayakpaul deleted the add-negative-prompt-docs branch January 12, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants