Skip to content

Conversation

@guiyrt
Copy link
Contributor

@guiyrt guiyrt commented Jan 13, 2025

What does this PR do?

Adds support for image prompting via IP-Adapter for StableDiffusion3ControlNetInpaintingPipeline.

Part of #9966

Before submitting

Who can review?

@hlky @yiyixuxu

I mentioned in #9966 that I didn't find an inpainting controlnet for SD3.5 Large, and the only IP-Adapter available is for SD3.5 Large afaik, so we can't really test it properly if that's the case.

Copy link
Contributor

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guiyrt. As you pointed out we may be unable to test this due to incompatible checkpoint availability however as the code is all Copied from it should be ok and ready for potential future releases. Could you take a look at the Copied from check and run make fix-copies?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@guiyrt
Copy link
Contributor Author

guiyrt commented Jan 13, 2025

Thanks @guiyrt. As you pointed out we may be unable to test this due to incompatible checkpoint availability however as the code is all Copied from it should be ok and ready for potential future releases. Could you take a look at the Copied from check and run make fix-copies?

Yeah, I just noticed the test failed, on it already

Edit: It was just some different whitespaces, not sure how it happened, I ran make style && make quality

@yiyixuxu yiyixuxu added the roadmap Add to current release roadmap label Jan 13, 2025
@yiyixuxu yiyixuxu merged commit 9fc9c6d into huggingface:main Jan 13, 2025
12 checks passed
@guiyrt guiyrt deleted the sd3-controlnet-inpaint-ipadapter branch January 13, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roadmap Add to current release roadmap

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants