Skip to content

[fix] refer use_framewise_encoding on AutoencoderKLHunyuanVideo._encode #10600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025
Merged

[fix] refer use_framewise_encoding on AutoencoderKLHunyuanVideo._encode #10600

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef61448
fix: refer to use_framewise_encoding on AutoencoderKLHunyuanVideo._en…
hanchchch Jan 17, 2025
1adc2a1
fix: comment about tile_sample_min_num_frames
hanchchch Jan 17, 2025
081dcc1
Merge branch 'main' into patch-1
a-r-r-o-w Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/diffusers/models/autoencoders/autoencoder_kl_hunyuan_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ def __init__(
self.use_tiling = False

# When decoding temporally long video latents, the memory requirement is very high. By decoding latent frames
# at a fixed frame batch size (based on `self.num_latent_frames_batch_sizes`), the memory requirement can be lowered.
# at a fixed frame batch size (based on `self.tile_sample_min_num_frames`), the memory requirement can be lowered.
self.use_framewise_encoding = True
self.use_framewise_decoding = True

Expand Down Expand Up @@ -868,7 +868,7 @@ def disable_slicing(self) -> None:
def _encode(self, x: torch.Tensor) -> torch.Tensor:
batch_size, num_channels, num_frames, height, width = x.shape

if self.use_framewise_decoding and num_frames > self.tile_sample_min_num_frames:
if self.use_framewise_encoding and num_frames > self.tile_sample_min_num_frames:
return self._temporal_tiled_encode(x)

if self.use_tiling and (width > self.tile_sample_min_width or height > self.tile_sample_min_height):
Expand Down