Skip to content

Conversation

@lmxyy
Copy link
Contributor

@lmxyy lmxyy commented Jan 21, 2025

What does this PR do?

When using BF16 for training, the script raises the error of RuntimeError: Input type (float) and bias type (c10::BFloat16) should be the same due to accelerator's FP32 wrapper. This wrapper needs to be removed for evaluation.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul

Integrations:

HF projects:

-->

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayakpaul sayakpaul requested a review from linoytsaban January 21, 2025 07:07
Copy link
Collaborator

@linoytsaban linoytsaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sayakpaul sayakpaul merged commit 158a5a8 into huggingface:main Jan 21, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants