Remove cache migration script #10619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcuenca
reviewed
Jan 21, 2025
|
If I was maintainer I'd say no since it shouldn't break anything (just for users that did not touch diffusers for 2y). But agree that on paper it is a breaking change so I'll let the diffusers team decide :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to huggingface/transformers#35810.
This PR makes some cleaning in the
src/diffusers/utils/hub_utils.pyfile. The "move_cache" has been introduced inv0.14.0(Feb 2023). IMO, we can safely assume everyone got their cache moved by now. Worse case, someone that did not updatediffusersfor 2y will have to redownload some models if they update.Less dead code to maintain :)