Skip to content

Conversation

@a-r-r-o-w
Copy link
Contributor

Some minor refactors to make implementations consistent.

  • We already check for F.scaled_dot_product_attention in the attention processor init method (see here)
  • Removes docstrings from intermediate blocks since they are explained in the main transformer implementation
  • Additionally should we consider this comment and remove the NPU related logic in FluxSingleTransformerBlock? It might be backwards breaking though

@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu February 23, 2025 21:42
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@a-r-r-o-w a-r-r-o-w force-pushed the refactor/remove-additional-flux-code branch from 4eb87e9 to 45eb74f Compare February 23, 2025 22:01
@yiyixuxu
Copy link
Collaborator

Additionally should we consider #9751 (comment) comment and remove the NPU related logic in FluxSingleTransformerBlock? It might be backwards breaking though

let's remove it in this PR!
we could do deprecate if needed, but only for short-time, e.g like remove in 0.34.

@yiyixuxu
Copy link
Collaborator

other changes looks good to me!

@a-r-r-o-w
Copy link
Contributor Author

Thanks @yiyixuxu, I've added a deprecation warning for v0.34.0

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@yiyixuxu yiyixuxu merged commit 0404703 into main Feb 25, 2025
15 checks passed
@yiyixuxu yiyixuxu deleted the refactor/remove-additional-flux-code branch February 25, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants