-
Couldn't load subscription status.
- Fork 6.5k
[LoRA] feat: support non-diffusers lumina2 LoRAs. #10909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b201988
feat: support non-diffusers lumina2 LoRAs.
sayakpaul 11469a8
revert ipynb changes (but I don't know why this is required ☹️)
sayakpaul b584c21
Merge branch 'main' into non-diffusers-lumina2-lora
sayakpaul 8ef320b
Merge branch 'main' into non-diffusers-lumina2-lora
sayakpaul ceaeeb2
Merge branch 'main' into non-diffusers-lumina2-lora
sayakpaul 9e13453
Merge branch 'main' into non-diffusers-lumina2-lora
sayakpaul 490c027
Merge branch 'main' into non-diffusers-lumina2-lora
sayakpaul fb96995
empty
sayakpaul 5e0394f
Merge branch 'main' into non-diffusers-lumina2-lora
DN6 5d1224f
Merge branch 'main' into non-diffusers-lumina2-lora
yiyixuxu cf0ac55
Merge branch 'main' into non-diffusers-lumina2-lora
sayakpaul 1560736
Merge branch 'main' into non-diffusers-lumina2-lora
sayakpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this prefix specific to Lumina? Should we always just remove it?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not specific to Lumina2 but specific to external trainer libraries. In all the past iterations where we have supported non-diffusers LoRA checkpoints, we have removed it because it's not in the
diffuserscompatible format.We are not removing the prefix. We are using it to detect if the state dict is non-diffusers. If so, we are converting the state dict.
This is how rest of the non-diffusers checkpoints across different models have been supported in
diffusers.