Don't override torch_dtype and don't use when quantization_config is set
#11039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hlky
changed the title
torch_dtype when quantization_config is settorch_dtype and don't use when quantization_config is set
|
@hlky Hi! This is a good PR for me. Sometimes I forget to set |
DN6
reviewed
Mar 18, 2025
| f"Passed `torch_dtype` {torch_dtype} is not a `torch.dtype`. Defaulting to `torch.float32`." | ||
| ) | ||
|
|
||
| if quantization_config is not None and torch_dtype is not None: |
There was a problem hiding this comment.
In this case, if we were trying to set the dtype of the model e.g. FluxTransformer(quantization_config=BnBConfig, torch_dtype=torch.bfloat16) Wouldn't the dtype be overwritten and then get set to the BnB default float16?
There was a problem hiding this comment.
Yes looks like it, I think it's ok without this part.
hlky
commented
Mar 20, 2025
DN6
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://github.com/huggingface/diffusers/actions/runs/13800894621/job/38602946014#step:7:1904
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.