- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.5k
Modify the implementation of retrieve_timesteps in CogView4-Control. #11125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 52 commits
a97fca2
              c30ca7a
              5c25cd2
              44bfd4c
              a9f448e
              2cbdf35
              df83bf2
              8bba67a
              b9d864b
              5d2e994
              ebeb1e4
              95e8504
              940c23b
              7a68a3e
              2a81772
              1d91a24
              dff4b29
              050b97c
              b007be0
              25f4e4b
              7ffecbc
              b4e11e7
              efa0f41
              f55e3cc
              9410e46
              29b0c81
              52d4ebf
              65b3719
              90830ed
              71f9235
              19d7d27
              fe6287a
              2f74c4e
              264060e
              9a10ceb
              b6e10e7
              692e5cc
              fc3830c
              98a2417
              c774f45
              687faa4
              8abca19
              cbfeb0b
              347dd17
              775bb8c
              985baa9
              c2a1985
              88abb39
              3e3387e
              ddb31d3
              64637ef
              4174736
              8cdd36f
              785e230
              07ef22e
              1e93e98
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|  | @@ -68,7 +68,7 @@ def calculate_shift( | |||
| return mu | ||||
|  | ||||
|  | ||||
| # Copied from diffusers.pipelines.stable_diffusion.pipeline_stable_diffusion.retrieve_timesteps | ||||
| # Copied from diffusers.pipelines.cogview4.pipeline_cogview4.retrieve_timesteps | ||||
| def retrieve_timesteps( | ||||
| scheduler, | ||||
| num_inference_steps: Optional[int] = None, | ||||
|  | @@ -100,10 +100,20 @@ def retrieve_timesteps( | |||
| `Tuple[torch.Tensor, int]`: A tuple where the first element is the timestep schedule from the scheduler and the | ||||
| second element is the number of inference steps. | ||||
| """ | ||||
| # Copied from diffusers.pipelines.cogview4.pipeline_cogview4.retrieve_timesteps | ||||
|          | ||||
| # Copied from diffusers.pipelines.cogview4.pipeline_cogview4.retrieve_timesteps | 
This is not needed. Please also run make fix-copies after removing this to ensure that both the implementation in this file and in pipeline_cogview4.py is the same 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have completed the verification, running make fix-copies did not produce any errors or other improvement suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the # Copied from comment to point to CogView4 pipeline file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that how I understand it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the change here is correct @zRzRzRzRzRzRzR