Use ignore_cleanup_errors=True in TemporaryDirectory for Windows compatibility
#11246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@bot /style |
|
Style fixes have been applied. View the workflow run here. |
sayakpaul
reviewed
Apr 9, 2025
hlky
commented
Apr 9, 2025
| GenericAlias = List[int] | ||
|
|
||
|
|
||
| class TemporaryDirectory: |
There was a problem hiding this comment.
@sayakpaul See here. This is the 3.10 version of TemporaryDirectory with a few changes for 3.8 support. We are using this over tempfile.TemporaryDirectory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows tests using
tempfile.TemporaryDirectoryto run on Windows, the parameter was introduced in 3.10 so we include our ownTemporaryDirectorybased on the 3.10 version.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.