fix test_vanilla_funetuning failure on XPU and A100 #11263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matrix Yao <[email protected]>
Signed-off-by: Matrix Yao <[email protected]>
hlky
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Thanks @yao-matrix, the additional slice for A100 is appreciated!
|
Failing test is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make
pytest -rA tests/lora/test_lora_layers_sd.py::LoraIntegrationTests::test_vanilla_funetuningpass on XPU and A100.before this PR: XPU fail, A100 fail
after this PR: XPU pass, A100 pass
I've checked the output of 2 device, since this case's step is 2, so basically they are still noise at this timestep. But still can see perceptually similar.
@hlky , pls help review, thx. and also I changed the
test_float16_inference'sexpected_max_diffback to5e-2.