Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/diffusers/models/transformers/transformer_hidream_image.py
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,8 @@ def forward(
self,
hidden_states: torch.Tensor,
timesteps: torch.LongTensor = None,
encoder_hidden_states: torch.Tensor = None,
t5_encoder_hidden_states: torch.Tensor = None,
llama3_encoder_hidden_states: torch.Tensor = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename these to encoder_hidden_states_t5 and encoder_hidden_states_llama3 instead? This is so that it is consistent with our naming convention in things like HunyuanDiT/EasyAnimate

pooled_embeds: torch.Tensor = None,
img_sizes: Optional[List[Tuple[int, int]]] = None,
img_ids: Optional[torch.Tensor] = None,
Expand Down Expand Up @@ -773,9 +774,7 @@ def forward(
)
hidden_states = self.x_embedder(hidden_states)

T5_encoder_hidden_states = encoder_hidden_states[0]
encoder_hidden_states = encoder_hidden_states[-1]
encoder_hidden_states = [encoder_hidden_states[k] for k in self.config.llama_layers]
encoder_hidden_states = [llama3_encoder_hidden_states[k] for k in self.llama_layers]

if self.caption_projection is not None:
new_encoder_hidden_states = []
Expand All @@ -784,9 +783,9 @@ def forward(
enc_hidden_state = enc_hidden_state.view(batch_size, -1, hidden_states.shape[-1])
new_encoder_hidden_states.append(enc_hidden_state)
encoder_hidden_states = new_encoder_hidden_states
T5_encoder_hidden_states = self.caption_projection[-1](T5_encoder_hidden_states)
T5_encoder_hidden_states = T5_encoder_hidden_states.view(batch_size, -1, hidden_states.shape[-1])
encoder_hidden_states.append(T5_encoder_hidden_states)
t5_encoder_hidden_states = self.caption_projection[-1](t5_encoder_hidden_states)
t5_encoder_hidden_states = t5_encoder_hidden_states.view(batch_size, -1, hidden_states.shape[-1])
encoder_hidden_states.append(t5_encoder_hidden_states)

txt_ids = torch.zeros(
batch_size,
Expand Down
Loading
Loading