- 
                Notifications
    
You must be signed in to change notification settings  - Fork 6.5k
 
Add generic support for Intel Gaudi accelerator (hpu device) #11328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 2 commits
      Commits
    
    
            Show all changes
          
          
            6 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      2c6a028
              
                Add generic support for Intel Gaudi accelerator (hpu device)
              
              
                dsocek fd2e7bf
              
                Merge branch 'main' into hpu_support
              
              
                sayakpaul ae3c497
              
                Add loggers for generic HPU support
              
              
                dsocek baf75db
              
                Refactor hpu support with is_hpu_available() logic
              
              
                dsocek 04f2f55
              
                Fix style for hpu support update
              
              
                dsocek 15725c4
              
                Decouple soft HPU check from hard device validation to support HPU mi…
              
              
                dsocek File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this import to be always present?
?
Also, since we're setting some environment variables here, maybe we could
logger.debug()this info?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@regisss @sayakpaul
Thanks for the quick review!
@sayakpaul
Yes the import is needed, else we will get error
ModuleNotFoundError: No module named 'torch.hpu'. This requirement is also documented here (see step 2).Good idea to add
logger.debug(), I will add this next.