Skip to content

Conversation

@sayakpaul
Copy link
Member

What does this PR do?

  • Propagates hotswap in load_lora_weights() where it was missing.
  • Simplifies the docstrings.
  • Fixes some type-annotations.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending the hotswap support to further classes, adding type annotations, and for simplifying the docstring by using references. LGTM

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@sayakpaul sayakpaul merged commit 29d2afb into main Apr 17, 2025
31 of 32 checks passed
@sayakpaul
Copy link
Member Author

Failing tests are unrelated.

@sayakpaul sayakpaul deleted the propagate-hotswap-better branch April 17, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants