[Refactor] Initialize class members inside init method #11450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…fusers into fixes-issue-11002
|
@DN6, gentle ping |
yiyixuxu
reviewed
Jun 16, 2025
| scheduler: KarrasDiffusionSchedulers, | ||
| ): | ||
| super().__init__() | ||
| self._guidance_scale = 1.0 |
There was a problem hiding this comment.
i would suggest:
1 .default _guidance_scale to be same as each pipeline call default, e.g. 7.5 here
2 _num_stesps can be None here since it is not yet known
but let me know all your thoughts @DN6 @ishan-modi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11002
Who can review?
@DN6 @yiyixuxu